Update ActionButton.vue to permit custom button classes to be truly customized #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will be merged within next week! |
|
What do you think, if to add flexibility to add/modify classes for buttons container as well? I mean by using E.g. When there are more buttons - it's barely usable on mobile. It could be fixed by using some flex classes on smaller screen, but now it's not possible. E.g. Could be something like this in mobile. Or, at least maybe having default style as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an example, specifying
->classes(['rounded-full'])on an action button would have no effect unless the default 'rounded' class is removed.This change make custom classes specified on an Action Button replace the non-essential default classes instead of merging with them.