COMPATIBILITY: Modernize the component #11
Conversation
DEV: Resolve compatibility with upcoming core changes
UX: Fix text flickering on hover
| @@ -81,7 +81,7 @@ | |||
| } | |||
|
|
|||
| // hide on scroll when nav is positioned to left of header: | |||
| .title .custom-header-links.scrolling { | |||
| .d-header .custom-header-links.scrolling { | |||
There was a problem hiding this comment.
The plugin outlet wrapper is not inside .title.
|
@Arkshine Amazing stuff! |
|
@nolosb Would you mind reviewing this one? |
|
@Arkshine checks are failing currently? |
merefield
changed the title
I think we can use the Discourse theme reusable workflow here. It refers to https://github.com/discourse/.github/blob/main/.github/workflows/discourse-theme.yml. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
| @@ -25,6 +25,7 @@ export default class CustomHeaderDropdown extends Component { | |||
| <li | |||
| class="custom-header-dropdown-link" | |||
| title={{@item.title}} | |||
| role="button" | |||
There was a problem hiding this comment.
This fixes the "Interaction added to non-interactive element" error.
https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-invalid-interactive.md
Ideally, I think we want to use <a> link here for better accessibility.
That's something I will see to change in another PR.
|
@nolosb Is currently unavailable, however Github is suggesting @nathan-nz review this :) 
What do you think @nathan-nz? |
I'm no dev (as you know!) so it won't be an expert review. But I am very happy to approve it as it has had your and @merefield's eyes on it (and @Arkshine is trustworthy). |
|
@Arkshine - I'm not sure what this means: |
|
@nathan-nz Yes, I've removed the workflow. Since we are using the Discourse reusable workflow, and the test part is already included, it was a duplicate. https://github.com/discourse/.github/blob/main/.github/workflows/discourse-theme.yml#L109 |
This PR modernizes the components:
The HTML structure and CSS classes should be the same.
NVIDIA_Share_Xnvy8FsB5i.mp4