Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass in chorus style to processline #26

Merged
merged 2 commits into from
Nov 7, 2023
Merged

pass in chorus style to processline #26

merged 2 commits into from
Nov 7, 2023

Conversation

jeremiahlukus
Copy link
Collaborator

Fixes
#25
Pre Changes:

Screenshot 2023-11-04 at 1 15 30 PM

Post Changes:

Screenshot 2023-11-04 at 1 15 50 PM

@jeremiahlukus
Copy link
Collaborator Author

Writing a test for this one sec

@jeremiahlukus
Copy link
Collaborator Author

Ok good to go

@jeremiahlukus
Copy link
Collaborator Author

jeremiahlukus commented Nov 6, 2023 •
edited
Loading

@paurakhsharma Mind merging this? I want to add the ability to pass in the scroll controller next
#16
Since they didnt clean it up ill submit a new PR to add this.

@paurakhsharma
Copy link
Owner

Hey @jeremiahlukus thank you so much for the PR. I'll have a look at it tomorrow and merge it.

@paurakhsharma paurakhsharma merged commit 6b8ce56 into main Nov 7, 2023
2 checks passed
@paurakhsharma paurakhsharma deleted the jlp-chorus-spacing branch November 7, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paurakhsharma paurakhsharma paurakhsharma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremiahlukus @paurakhsharma