Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If verse number is present carry it next line #23

Closed
wants to merge 25 commits into from

Conversation

jeremiahlukus
Copy link
Collaborator

@jeremiahlukus jeremiahlukus commented Oct 31, 2023

i changed the example to

[C]In the streets our, [F]hands are lifting
[Am]As we lose our, [G]inhibition
[C]Celebration, [F]its around us
[Am]Every nation, [G]all around us

1
[C]Give me Freedom, [F]Give me fire
[Am]Give me reason, [G]Take me higher
[C]See the champions [F], Take the field now
[Am]Unify us, [G]make us feel proud

if the verse number is present move it to the side.
linked to #21

This does add a bit of padding to the side which i like, I wrap all of this in a if statement and pass in a new bool to LyricsRenderer called formatVerse if this is a change you want.

Screenshot 2023-10-31 at 8 53 50 AM

@jeremiahlukus
Copy link
Collaborator Author

jeremiahlukus commented Nov 3, 2023

Going to close this i think this might too custom to be in this package. If not let me know and ill reopen

@paurakhsharma
Copy link
Owner

Yes, I think this is too custom to be in a package. We can achieve this using the directive I mentioned in the issue.
For your app maybe it's better if you add the intermediary step to convert your carry line to directive before passing it to LyricsRenderer, or maybe run a migration on your lyrics set if it is an asset, but if it comes from the server it might be little more tricky.

@jeremiahlukus
Copy link
Collaborator Author

I agree, for now I'll keep pulling from my fork when I have time to reformat all my lyrics I'll add this.
Other than that if i find more bugs I'll submit a PR.

@paurakhsharma
Copy link
Owner

Great, thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants