Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment directive #20

Merged
merged 20 commits into from
Oct 26, 2023
Merged

Add comment directive #20

merged 20 commits into from
Oct 26, 2023

Conversation

jeremiahlukus
Copy link
Collaborator

https://www.chordpro.org/chordpro/directives-comment/

All comments should be in the format {comment: Repeat}

Account to the chord prod format it should be italic and smaller by default.

I also added ChordLyricsLine tests since its has logic inside of it.

If you merge this Please squash to one commit I was watching TV while doing this ha.

Here is a pic of the lyrics and the song rendering.
Screenshot 2023-10-22 at 10 41 35 PM

@jeremiahlukus
Copy link
Collaborator Author

I also added a trim in all the model methods I feel like this should be included.

I removed flutter format in the workflow and replaced with dart format since this is the recommend way now.

@jeremiahlukus
Copy link
Collaborator Author

@paurakhsharma Let me know if this is a wanted change or not. If not then ill publish a fork so im not pulling from git.

@paurakhsharma
Copy link
Owner

@jeremiahlukus Thank you so much for the contribution. I'll have a look at it tonight and merge it.

Copy link
Owner

@paurakhsharma paurakhsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for your contribution.

@paurakhsharma paurakhsharma merged commit 5e4f9da into paurakhsharma:main Oct 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants