-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comment directive #20
Conversation
I also added a trim in all the model methods I feel like this should be included. I removed flutter format in the workflow and replaced with dart format since this is the recommend way now. |
@paurakhsharma Let me know if this is a wanted change or not. If not then ill publish a fork so im not pulling from git. |
@jeremiahlukus Thank you so much for the contribution. I'll have a look at it tonight and merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for your contribution.
https://www.chordpro.org/chordpro/directives-comment/
All comments should be in the format
{comment: Repeat}
Account to the chord prod format it should be italic and smaller by default.
I also added ChordLyricsLine tests since its has logic inside of it.
If you merge this Please squash to one commit I was watching TV while doing this ha.
Here is a pic of the lyrics and the song rendering.