This repository has been archived by the owner on Sep 18, 2019. It is now read-only.
Google Fonts improvements #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lback for when no API key is set. API key is now set via definition rather than hard coded into the framework
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides fallback to stored data when no API key set.
API key is set via definition instead of hard coding into the framework which meant that the framework needed to be modified to use it.
Caching to disk has been removed and replaced with the transients API.
These changes should allow themes using the Google Fonts section of this library to be accepted into the official WordPress theme repository and allow it to work with a broader range of setups and use cases.
I've done very little testing with this. It's just a quick thing I hacked together to solve a problem I was working on, but AFAIK I should work just fine and I'm not aware of any problems with it.