This repository has been archived by the owner on Oct 29, 2020. It is now read-only.
Fixing AlertChannels Configuration type #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrombley
force-pushed
the
SupportHeaderPayloadMapsInAlertChannelConfiguration
branch
from
46a067c
to
4aa9d17
Compare
|
Rebased on the master branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When requesting AlertChannels that are of type webhook, the Headers and Payload fields are being treated as strings when they are actually maps.
The AlertChannel struct has been updated to have a Configuration field of type AlertChannelConfiguration which treats all fields as strings as before. However, Headers and Payload has been updated to be a map.