Change snippet locking basing it on edit snippets #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakonig
approved these changes
Sep 20, 2023
minottic
force-pushed
the
lock_snip
branch
2 times, most recently
from
ea92415
to
56c9489
Compare
|
I have implemented the locking on load and added to this PR for ease of review |
|
it's on dev if you wanna try it out |
minottic
force-pushed
the
lock_snip
branch
2 times, most recently
from
c9a0eeb
to
dbcba7f
Compare
wakonig
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only covers the websocket locking, the locking on loading the page is not yet implemented and will come in another PR, as it implements a newer feature