Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace io/ioutils as it is deprecated #45

Merged
merged 1 commit into from
May 16, 2024
Merged

Replace io/ioutils as it is deprecated #45

merged 1 commit into from
May 16, 2024

Conversation

kavir1698
Copy link
Collaborator

No description provided.

@kavir1698 kavir1698 requested a review from a team April 22, 2024 13:38
minottic
minottic approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@minottic minottic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust this is covered already by tests

@kavir1698
Copy link
Collaborator Author

These are not covered by tests. But they are safe changes as the deprecated function is simply calling the new function.

@kavir1698 kavir1698 merged commit 8750a2c into main May 16, 2024
3 checks passed
@kavir1698 kavir1698 deleted the replace-deprecated-libraries branch May 16, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minottic minottic minottic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kavir1698 @minottic