Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/various fixes 2 #106

Merged
merged 5 commits into from
Aug 27, 2024
Merged

Refactor/various fixes 2 #106

merged 5 commits into from
Aug 27, 2024

Conversation

consolethinks
Copy link
Collaborator

@consolethinks consolethinks commented Aug 26, 2024 •
edited
Loading

Just a couple of commits that fix a few issues:

  • adds a few extra comments to datasetIngestor
  • adds a few extra log messages to datasetIngestor
  • "skip" variable has been renamed to skipSymlinks for better clarity
  • re-added the reset block for skipSymlinks for maintaining previous behaviour
  • fix an error message in ingestDataset

Recreated from refactor/various_fixes due to a few issues with conflicts

@consolethinks consolethinks merged commit 62fda76 into main Aug 27, 2024
3 checks passed
@consolethinks consolethinks deleted the refactor/various_fixes_2 branch August 27, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minottic minottic minottic approved these changes

@sbliven sbliven Awaiting requested review from sbliven

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@consolethinks @minottic