Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/check central data #100

Merged
merged 6 commits into from
Aug 19, 2024
Merged

Refactor/check central data #100

merged 6 commits into from
Aug 19, 2024

Conversation

consolethinks
Copy link
Collaborator

Refactors checkDataCentrallyAvailable:

  • error handling instead of logs
  • ssh command's output is output into an io.Writer parameter
  • error message improvements

@sbliven sbliven mentioned this pull request Aug 19, 2024
Closed
minottic
minottic approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@minottic minottic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the commented logs, otherwise looks good, thanks!

@consolethinks consolethinks merged commit 54b6a20 into main Aug 19, 2024
3 checks passed
@consolethinks consolethinks deleted the refactor/check_central_data branch August 19, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minottic minottic minottic approved these changes

@sbliven sbliven Awaiting requested review from sbliven

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@consolethinks @minottic