fixing aram

pauloendoh · Jun 3, 2024 · 8cf9438 · 8cf9438
1 parent 0f30200
commit 8cf9438
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 331 deletions.
diff --git a/...ains/lolrates/aram-controller/use-case/_CacheLolGraphAramStats/_CacheLolGraphAramStats.ts b/...ains/lolrates/aram-controller/use-case/_CacheLolGraphAramStats/_CacheLolGraphAramStats.ts
@@ -74,8 +74,6 @@ export class _CacheLolGraphAramStats {
       60 * 60 * 24 // 1 day
     )
 
-    await browser.close()
-
     return x
 
     //   let html = ""

diff --git a/src/malLoop.ts b/src/malLoop.ts
diff --git a/src/utils/lolrates/scrapeLolRates/scrapeAram.ts b/src/utils/lolrates/scrapeLolRates/scrapeAram.ts
@@ -14,7 +14,10 @@ export async function scrapeAram(page: Page) {
   try {
     let aramResults: AramChampionData[] = []
 
-    await page.goto(`https://www.op.gg/modes/aram`)
+    await page.goto(`https://www.op.gg/modes/aram`, {
+      waitUntil: "load",
+      timeout: 0,
+    })
 
     await page.waitForSelector("tbody")
     await sleep(500) // waiting for champions sort
@@ -29,7 +32,7 @@ export async function scrapeAram(page: Page) {
           const tds = tr.querySelectorAll("td")
           const championTd = tds[1]
           const championName =
-            championTd?.querySelector("strong")?.textContent || ""
+            championTd?.querySelector("strong")?.textContent ?? ""
           const winRate = tds[3].innerText
 
           roleResults.push({

diff --git a/src/utils/lolrates/scrapeLolRates/scrapeOpgg.ts b/src/utils/lolrates/scrapeLolRates/scrapeOpgg.ts
@@ -49,15 +49,15 @@ export async function scrapeOpgg(page: Page) {
 
           const roleResults: IOpggResult[] = []
           const tbody = document.querySelector("tbody")
-          const trs = Array.from(tbody?.querySelectorAll("tr") || [])
+          const trs = Array.from(tbody?.querySelectorAll("tr") ?? [])
 
           for (const tr of trs) {
             const tds = tr.querySelectorAll("td")
             const championTd = tds[1]
             const championName =
-              championTd?.querySelector("strong")?.textContent || ""
-            const winRate = tds[3].innerText
-            const pickRate = tds[4].innerText
+              championTd?.querySelector("strong")?.textContent ?? ""
+            const winRate = tds[4].innerText
+            const pickRate = tds[5].innerText
 
             roleResults.push({
               role: getRole(),
@@ -72,7 +72,7 @@ export async function scrapeOpgg(page: Page) {
       )
     }
 
-    const saved = await LolRateRepository.saveOpgg(allRolesResults)
+    await LolRateRepository.saveOpgg(allRolesResults)
     myConsoleSuccess(`OP GG OK: ${allRolesResults.length} results`)
 
     return

diff --git a/src/utils/mal/scrapeMal.ts b/src/utils/mal/scrapeMal.ts
diff --git a/src/utils/mal/scrapeMalUser/scrapeMalUser.ts b/src/utils/mal/scrapeMalUser/scrapeMalUser.ts
diff --git a/src/utils/mal/scrapeMalUser/scrapeMalUserFriends/scrapeMalUserFriends.ts b/src/utils/mal/scrapeMalUser/scrapeMalUserFriends/scrapeMalUserFriends.ts
diff --git a/src/utils/mal/scrapeMalUser/scrapeUser/scrapeUser.ts b/src/utils/mal/scrapeMalUser/scrapeUser/scrapeUser.ts