noble-secp256k1 is not handling properly the point at infinity (#121)

* fix Point.fromAffine * new build * formatting * new build * formatting & new build * Fix formatting --------- Co-authored-by: Elli610 <[email protected]> Co-authored-by: Paul Miller <[email protected]>
paulmillr · Feb 19, 2024 · d9aabe9 · d9aabe9
1 parent 24f89fd
commit d9aabe9
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 12 deletions.
diff --git a/index.js b/index.js
@@ -26,7 +26,12 @@ class Point {
         this.py = py;
         this.pz = pz;
     } //3d=less inversions
-    static fromAffine(p) { return new Point(p.x, p.y, 1n); }
+    static fromAffine(p) {
+        if ((p.x === 0n) && (p.y === 0n))
+            return new Point(0n, 1n, 0n);
+        else
+            return new Point(p.x, p.y, 1n);
+    }
     static fromHex(hex) {
         hex = toU8(hex); // convert hex string to Uint8Array
         let p = undefined;

diff --git a/index.ts b/index.ts
@@ -26,7 +26,10 @@ class Point {                                           // Point in 3d xyz proje
   constructor(readonly px: bigint, readonly py: bigint, readonly pz: bigint) {} //3d=less inversions
   static readonly BASE = new Point(Gx, Gy, 1n);         // Generator / base point
   static readonly ZERO = new Point(0n, 1n, 0n);         // Identity / zero point
-  static fromAffine(p: AffinePoint) { return new Point(p.x, p.y, 1n); }
+  static fromAffine (p: AffinePoint) {
+    if ((p.x === 0n) && (p.y === 0n)) return Point.ZERO;
+    else return new Point(p.x, p.y, 1n) ;
+  }
   static fromHex(hex: Hex): Point {                     // Convert Uint8Array or hex string to Point
     hex = toU8(hex);                                    // convert hex string to Uint8Array
     let p: Point | undefined = undefined;

diff --git a/package-lock.json b/package-lock.json