Merge pull request #39 from pauldmccarthy/rf/change_seek_error

Rf/change seek error

CHANGELOG.md

@@ -1,6 +1,14 @@
 # `indexed_gzip` changelog
 
 
+## 1.3.1 (June 25th 2020)
+
+
+* Reverted the error type raised by the `IndexedGzipFile.seek` to `ValueError`,
+  as `nibabel` assumes that the `seek` method of file objects raise a
+  `ValueError` if `SEEK_END` is not supported.
+
+
 ## 1.3.0 (June 24th 2020)
 
 

indexed_gzip/__init__.py

@@ -14,4 +14,4 @@
                            ZranError)
 
 
-__version__ = '1.3.0'
+__version__ = '1.3.1'

indexed_gzip/indexed_gzip.pyx

@@ -457,8 +457,8 @@ cdef class _IndexedGzipFile:
                                   'offset {}'.format(offset))
 
         elif ret == zran.ZRAN_SEEK_INDEX_NOT_BUILT:
-            raise NotCoveredError('Index must be completely built '
-                                  'in order to seek from SEEK_END')
+            raise ValueError('Index must be completely built '
+                             'in order to seek from SEEK_END')
 
         elif ret not in (zran.ZRAN_SEEK_OK, zran.ZRAN_SEEK_EOF):
             raise ZranError('zran_seek returned unknown code: {}'.format(ret))

indexed_gzip/tests/ctest_indexed_gzip.pyx

@@ -332,7 +332,7 @@ def test_seek(concat):
             results.append((f.read(8), 5))
 
             # SEEK_END only works when index is built
-            with pytest.raises(igzip.NotCoveredError):
+            with pytest.raises(ValueError):
                 f.seek(-100, SEEK_END)
 
             f.build_full_index()