Skip to content

Commit

Permalink
Merge pull request #143 from pauldmccarthy/ci/fix-builds
Browse files Browse the repository at this point in the history
MNT: Remove numpy as a build-time dependency
  • Loading branch information
pauldmccarthy authored Nov 6, 2023
2 parents a09f2e2 + f3197cc commit 3cfc54c
Show file tree
Hide file tree
Showing 7 changed files with 1,176 additions and 1,343 deletions.
31 changes: 16 additions & 15 deletions .ci/build_wheels.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,26 +21,27 @@ export CIBW_TEST_REQUIRES="cython pytest numpy nibabel coverage cython-coverage
# history [GHA logs of failing builds deleted]).
export CIBW_SKIP="pp*"

# Make sure numpy can be built without BLAS being present
# (it may end up being built from source on some platforms)
# https://github.com/numpy/numpy/issues/24703#issuecomment-1722379388
export PIP_CONFIG_SETTINGS='setup-args="-Dallow-noblas=true"'

# Skip i686 tests - I have experienced hangs on these
# platforms, which I traced to a trivial numpy operation -
# "numpy.linalg.det(numpy.eye(3))". This occurs when numpy
# has to be compiled from source during the build, so can
# be re-visited if/when numpy is avaialble on all platforms.
# Skip i686 and aarch64 tests

# - I have experienced hangs on these platforms,
# which I traced to a trivial numpy operation -
# "numpy.linalg.det(numpy.eye(3))".

# - Numpy wheels are not available for these
# platforms, so has to be compiled from source
# during the build, which massively increases
# build time and complexity.
#
# Skip py312 tests on Windows due to unresolved test failures.
export CIBW_TEST_SKIP="*i686* cp312-win*"
# Skip py312 tests on Windows due to unresolved
# test failures.
export CIBW_TEST_SKIP="*i686* *aarch64* cp312-win*"

# Pytest makes it *very* awkward to run tests
# from an installed package, and still find/
# interpret a conftest.py file correctly.
echo '#!/usr/bin/env bash' > testcmd
echo 'cp $1/pyproject.toml .' >> testcmd
echo 'python -m indexed_gzip.tests -c pyproject.toml --no-cov -m "not slow_test"' >> testcmd
echo '#!/usr/bin/env bash' > testcmd
echo 'cp $1/pyproject.toml .' >> testcmd
echo 'python -m indexed_gzip.tests -c pyproject.toml --no-cov -m "not slow_test" -k "not test_zran"' >> testcmd
chmod a+x testcmd

export CIBW_TEST_COMMAND="bash {project}/testcmd {project}"
Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
# `indexed_gzip` changelog


## 1.8.7 (November 2nd 2023)
## 1.8.7 (November 6th 2023)


* Enable Python 3.12 and `musllinux` builds (#139).
* Remove `numpy` as a mandatory build-time dependency (#142, #143).


## 1.8.5 (August 29th 2023)
Expand Down
Loading

0 comments on commit 3cfc54c

Please sign in to comment.