Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: react 17 support #399

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

andrewsantarin
Copy link
Contributor

The React developers have released v17 since October 2020. With these changes, we would be able to support the latest React version.

Resolves #398

Description

  • Widened the supported range of react & react-dom peerDependencies.
  • Bumped devDependencies to support React v17.
  • Tweaked Enzyme jest tests to support React v17.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have used ESLint & Prettier to follow the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

import Adapter from 'enzyme-adapter-react-16'
import Adapter from '@wojtekmaj/enzyme-adapter-react-17'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enzymejs/enzyme#2429 (comment) indicates that the Enzyme maintainers won't be releasing support soon, so here's the drop-in replacement.

@andycansdale
Copy link

Any chance this could be merged? We are currently waiting on it. Thanks @andrewsantarin for doing the PR!

@geekdaniels
Copy link

Well done on this @andrewsantarin. Any luck with the merge @patw0929 ? Cheers

@lrocheWB
Copy link

@patw0929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm ERR! Could not resolve dependency: npm ERR! peer react@">15.4.2 <17.0.0" from [email protected]
4 participants