This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Add configurable compression #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pyo3 create_dataset function now optionally takes a string which is the JSON-serialized compression config (defaulting to Gzip -1). Keys can be
"snake_case"instead of"camelCase", because serde.This is a MVP for getting the information from python to rust, while still keeping all the flexibility that N5 has and may use in future (currently all of specified compression options have a single integer parameter). I personally would expect users to err on the side of using the (eventual) h5py-like interface, in which case smarter things could be done with compression parameters as it's in python, where create_dataset is not.