Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): hasSlotted SSR hints #2845

Merged
merged 9 commits into from
Dec 4, 2024

Conversation

bennypowers
Copy link
Member

What I did

  1. adds ssr-only ssr-hint-has-slotted="slotA,default,slotB" attribute to elements which use SlotController

Testing Instructions

  1. view and verify results for pf-card.e2e.ts

Notes to Reviewers

  1. Not entirely sure how best to document this, but i'm mostly certain I don't want to add this to individual element docs, but rather on a centralized ssr docs page

adds ssr-only `ssr-hint-has-slotted="slotA,default,slotB"` attribute to
elements which use SlotController
Copy link

changeset-bot bot commented Sep 15, 2024

⚠️ No Changeset found

Latest commit: f470aaa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 15, 2024

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "feat(core): hasSlotted SSR hints"
}

@github-actions github-actions bot added the AT passed Automated testing has passed label Sep 15, 2024
Copy link

netlify bot commented Sep 15, 2024

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 0a513b5
😎 Deploy Preview https://deploy-preview-2845--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

SSR Test Run for 88b8804: Report

Copy link
Contributor

SSR Test Run for 1d93145: Report

Copy link
Contributor

github-actions bot commented Dec 3, 2024

SSR Test Run for 8f99c41: Report

Copy link
Collaborator

@zeroedin zeroedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the one comment on the test, otherwise LGTM

@bennypowers bennypowers enabled auto-merge (squash) December 4, 2024 12:05
@bennypowers bennypowers merged commit 5940f37 into main Dec 4, 2024
14 of 15 checks passed
@bennypowers bennypowers deleted the feat/ssr/slot-controller-has-slotted branch December 4, 2024 12:05

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT passed Automated testing has passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants