-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): hasSlotted SSR hints #2845
Conversation
adds ssr-only `ssr-hint-has-slotted="slotA,default,slotB"` attribute to elements which use SlotController
|
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "feat(core): hasSlotted SSR hints"
} |
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just the one comment on the test, otherwise LGTM
What I did
ssr-hint-has-slotted="slotA,default,slotB"
attribute to elements which use SlotControllerTesting Instructions
Notes to Reviewers