fix(select): presence of placeholder in ax tree

patternfly · Apr 11, 2024 · 74179fd · 74179fd
1 parent 7301428
commit 74179fd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/elements/pf-select/pf-option.ts b/elements/pf-select/pf-option.ts
@@ -28,7 +28,7 @@ export class PfOption extends LitElement {
   /** form value for this option */
   @property({ reflect: true })
   get value() {
-    return this.#value ?? this.textContent ?? '';
+    return (this.#value ?? this.textContent ?? '').trim();
   }
 
   set value(v: string) {

diff --git a/elements/pf-select/pf-select.ts b/elements/pf-select/pf-select.ts
@@ -290,7 +290,7 @@ export class PfSelect extends LitElement {
                class="${classMap({ checkboxes })}">
             <pf-option id="placeholder"
                        disabled
-                       aria-hidden="${String(hasSelection) as 'true' | 'false'}"
+                       aria-hidden="${ifDefined(hasSelection ? 'true' : undefined)}"
                        ?hidden="${!this.placeholder && !this.#slots.hasSlotted('placeholder')}">
               <slot name="placeholder">${this.placeholder}</slot>
             </pf-option>