Manually provide vertical insets to LineCartesianLayer #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyler-Lopez
commented
Nov 1, 2024
Comment on lines
-578
to
-579
| unscalableStartPadding = maxPointSize.half + layerPadding.unscalableStartDp.pixels, | ||
| unscalableEndPadding = maxPointSize.half + layerPadding.unscalableEndDp.pixels, |
There was a problem hiding this comment.
I'm wondering if there is anything lost in not using ExtraStore any longer to derive even the previous change to CartesianLayerPadding and if it is worse to commit to that further like this PR would.
There was a problem hiding this comment.
I'm very crudely exploring an extrastore exposing alternative, where we take the "Provider" paradigm here
Tyler-Lopez
force-pushed
the
lopez/remove-largest-point
branch
from
3186703
to
4d4aeef
Compare
Gowsky
force-pushed
the
master
branch
3 times, most recently
from
c357b92
to
05150c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP PR which is in response to: #939