Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

160 js deps update #162

Merged
merged 13 commits into from
Jan 13, 2023
Merged

160 js deps update #162

merged 13 commits into from
Jan 13, 2023

Conversation

ccorda
Copy link
Contributor

@ccorda ccorda commented Dec 30, 2022

refs #160

While updating client-side deps, it looks like several dependencies have now gone from dual suppoer of CJS and ESM to ESM only.

I found this article, which had a good overview on how to handle this, which I followed as a template.
https://gist.github.com/noraj/007a943dc781dc8dd3198a29205bae04

@ccorda ccorda requested a review from chrisherold January 3, 2023 22:42
@ccorda ccorda changed the title 160 js 160 js deps update Jan 12, 2023
@ccorda ccorda requested a review from kylehotchkiss January 12, 2023 03:35
@ccorda
Copy link
Contributor Author

ccorda commented Jan 12, 2023

@kylehotchkiss or @chrisherold this is ready for review. Should be able to take this site for a spin, and successfully run gulp.

@kylehotchkiss
Copy link
Member

After running nvm use, yarn, and gulp release, I encounter an issue with the scripts step:

❯ gulp release  
[10:52:17] Using gulpfile ~/Work/bubs-timber/gulpfile.mjs
[10:52:17] Starting 'release'...
[10:52:17] Starting 'clean'...
[10:52:17] Finished 'release' after 3.94 ms
[10:52:17] Finished 'clean' after 16 ms
[10:52:17] Starting 'styles'...
[10:52:25] Finished 'styles' after 8.21 s
[10:52:25] Starting 'scripts'...
[10:52:26] 'scripts' errored after 66 ms
[10:52:26] TypeError: Cannot read properties of undefined (reading 'debug')
    at scripts (file:///Users/kylehotchkiss/Work/bubs-timber/gulpfile.mjs:169:51)
    at bound (node:domain:433:15)
    at runBound (node:domain:444:12)
    at asyncRunner (/Users/kylehotchkiss/Work/bubs-timber/node_modules/async-done/index.js:55:18)
    at process.processTicksAndRejections (node:internal/process/task_queues:77:11)

@ccorda
Copy link
Contributor Author

ccorda commented Jan 13, 2023

Thanks @kylehotchkiss. release now working. Also fixed half of the issue in #163.

@ccorda ccorda mentioned this pull request Jan 13, 2023
@ccorda ccorda merged commit 9d029a2 into main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants