Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: stellate changes from testing #309

Merged
merged 3 commits into from
Oct 17, 2024
Merged

refactor: stellate changes from testing #309

merged 3 commits into from
Oct 17, 2024

Conversation

ccorda
Copy link
Contributor

@ccorda ccorda commented Aug 4, 2024

refs #307

Fixed a few issues after debugging:

When we purged all, we weren't getting anything back that we could use to determine the URL to revalidate. Only workaround I could find was to call the admin API directly with a mutation query.
When that happens, we have to handle the vercel revalidation ourselves. So we do.
To make logging easier, added a flag (default to false) that will log to error_log. This can be run locally or on production.
Handled disabling and enabling, and making sure the token gets saved.

Copy link

vercel bot commented Aug 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
bubs-next ❌ Failed (Inspect) Oct 17, 2024 3:15pm

@ccorda ccorda requested a review from chrisherold August 4, 2024 20:01
@ccorda ccorda changed the title stellate changes from testing refactor: stellate changes from testing Aug 8, 2024
@ccorda ccorda merged commit aa2b2b6 into main Oct 17, 2024
1 of 2 checks passed
@ccorda ccorda deleted the 307-stellate-r2 branch October 17, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant