Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to sdk style for easy CI/CD #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jamesmontemagno
Copy link

@jamesmontemagno jamesmontemagno commented May 11, 2018

[Edit (AP): Also removes all iOS Classic API support and unifies some whitespace inconsistencies.]

@patridge
Copy link
Owner

@jamesmontemagno Thank you for helping me get this converted. I'm finally getting around to building and testing all this locally.

While it isn't a huge problem, do you know if there is a fairly non-invasive way to avoid all the XML doc warnings?

…/src/PDRating/PDRatingView.cs(18,18): Warning CS1591: Missing XML comment for publicly visible type or member 'PDRatingView' (CS1591) (PDRating)

@jamesmontemagno
Copy link
Author

Oh you would just want to turn off warnings i guess. or comment it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants