Skip to content

Commit

Permalink
sunxi:cedar Make default config for cedar "m"
Browse files Browse the repository at this point in the history
Make the default build config setting for cedarx "m"

Signed-off-by: Patrick Wood <[email protected]>
  • Loading branch information
patrickhwood committed Oct 24, 2013
1 parent 4248eea commit 61de436
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/media/video/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -1225,6 +1225,7 @@ endif # V4L_MEM2MEM_DRIVERS

config VIDEO_SUNXI_CEDAR
tristate "CEDAR driver for sunxi"
default m
depends on ARCH_SUN4I || ARCH_SUN5I || ARCH_SUN7I
help
CEDAR driver for sunxi
Expand Down

6 comments on commit 61de436

@patrickhwood
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, needed to be "m" in two different Kconfigs to get the right default if not set in the _defconfig.

@patricius972
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this branch, and actually it does not work with libvecore , at least on my cb2. The dma coherence patch is needed or uncomment the allocation in case io_ram==0.

@patrickhwood
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patricius972
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, i'm trying to make xbmc works. I have started to patch it for this version of libcedarx, but no success for now. So i apply the flush cache to the cedarx-libs version, and that does not fix the artifact problems when calling flush_cash after mem_cpy , with the noncached allocation. I guess flushing the cache with the noncached allocation kernel as no effect ? Correct ! Thank you. I'll work from that and try to
see where is the difference between libcedarx et cedarx-libs.

@patrickhwood
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. cache flushing does not apply to noncached data.

Note that some artifacts with H.264 files require the Android libve and libhybris: linux-sunxi/cedarx-libs#1.

@patricius972
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, libhybris is too slow for me. I'm trying to get rid of the artifact in H264 in xbmc, either by using the new blobs (but i get a segfault at libve_open) or by patching xbmc to work with libcedarx (which start decoding but segfault, don't know yet how to retrieve the good picture pointer for xbmc). Last option will be to use some of the libvdpau code in xbmc when playing h264. I'm using archlinuxarm and i can't compile vlc properly, i need a newer version (2.1) with the patch, no one has done the merge as far as i know.

Please sign in to comment.