handle relation fields with maxSelect = null (#28)

when maxSelect = null (left empty), it accepts unlimitted number of values
patmood · Jan 2, 2023 · fd61e68 · fd61e68
1 parent cd0a573
commit fd61e68
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/src/lib.ts b/src/lib.ts
@@ -45,9 +45,9 @@ const pbSchemaTypescriptMap = {
       ? "string[]"
       : "string",
   relation: (fieldSchema: FieldSchema) =>
-    fieldSchema.options.maxSelect && fieldSchema.options.maxSelect > 1
-      ? `${RECORD_ID_STRING_NAME}[]`
-      : RECORD_ID_STRING_NAME,
+    fieldSchema.options.maxSelect && fieldSchema.options.maxSelect === 1
+      ? RECORD_ID_STRING_NAME
+      : `${RECORD_ID_STRING_NAME}[]`,
   // DEPRECATED: PocketBase v0.8 does not have a dedicated user relation
   user: (fieldSchema: FieldSchema) =>
     fieldSchema.options.maxSelect && fieldSchema.options.maxSelect > 1

diff --git a/test/lib.test.ts b/test/lib.test.ts
@@ -319,7 +319,7 @@ describe("createTypeField", () => {
         name: "relationField",
         type: "relation",
       })
-    ).toEqual("\trelationField: RecordIdString")
+    ).toEqual("\trelationField: RecordIdString[]")
   })
 
   it("converts relation type with multiple options", () => {
@@ -335,6 +335,19 @@ describe("createTypeField", () => {
     ).toEqual("\trelationFieldMany: RecordIdString[]")
   })
 
+  it("converts relation type with unset maxSelect", () => {
+    expect(
+      createTypeField("test_collection", {
+        ...defaultFieldSchema,
+        name: "relationFieldMany",
+        type: "relation",
+        options: {
+          maxSelect: null,
+        },
+      })
+    ).toEqual("\trelationFieldMany: RecordIdString[]")
+  })
+
   // DEPRECATED: This was removed in PocketBase v0.8
   it("converts user relation type", () => {
     expect(