Skip to content

Commit

Permalink
fix psalm issues
Browse files Browse the repository at this point in the history
  • Loading branch information
@DavidBadura
DavidBadura committed Sep 20, 2024
1 parent a8c883d commit 900711a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 105 deletions.
106 changes: 5 additions & 101 deletions baseline.xml
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<files psalm-version="5.25.0@01a8eb06b9e9cc6cfb6a320bf9fb14331919d505">
<files psalm-version="5.26.1@d747f6500b38ac4f7dfc5edbcae6e4b637d7add0">
<file src="src/Aggregate/AggregateRootBehaviour.php">
<UnsafeInstantiation>
<code><![CDATA[new static()]]></code>
Expand Down Expand Up @@ -124,13 +124,6 @@
<code><![CDATA[$methodName]]></code>
</MixedMethodCall>
</file>
<file src="tests/Benchmark/BasicImplementation/Profile.php">
<PropertyNotSetInConstructor>
<code><![CDATA[$email]]></code>
<code><![CDATA[$id]]></code>
<code><![CDATA[$name]]></code>
</PropertyNotSetInConstructor>
</file>
<file src="tests/Benchmark/PersonalDataBench.php">
<MissingConstructor>
<code><![CDATA[$multipleEventsId]]></code>
Expand Down Expand Up @@ -182,124 +175,35 @@
<code><![CDATA[$subscriptionEngine]]></code>
</MissingConstructor>
</file>
<file src="tests/Integration/BankAccountSplitStream/BankAccount.php">
<PropertyNotSetInConstructor>
<code><![CDATA[$balanceInCents]]></code>
<code><![CDATA[$id]]></code>
<code><![CDATA[$name]]></code>
</PropertyNotSetInConstructor>
</file>
<file src="tests/Integration/BasicImplementation/Profile.php">
<PropertyNotSetInConstructor>
<code><![CDATA[$id]]></code>
<code><![CDATA[$name]]></code>
</PropertyNotSetInConstructor>
</file>
<file src="tests/Integration/ChildAggregate/PersonalInformation.php">
<PropertyNotSetInConstructor>
<code><![CDATA[PersonalInformation]]></code>
</PropertyNotSetInConstructor>
</file>
<file src="tests/Integration/ChildAggregate/Profile.php">
<PropertyNotSetInConstructor>
<code><![CDATA[$id]]></code>
<code><![CDATA[$personalInformation]]></code>
</PropertyNotSetInConstructor>
</file>
<file src="tests/Integration/PersonalData/PersonalDataTest.php">
<MixedArgument>
<code><![CDATA[$row['payload']]]></code>
</MixedArgument>
</file>
<file src="tests/Integration/PersonalData/Profile.php">
<PropertyNotSetInConstructor>
<code><![CDATA[$id]]></code>
<code><![CDATA[$name]]></code>
</PropertyNotSetInConstructor>
</file>
<file src="tests/Integration/Store/Profile.php">
<PropertyNotSetInConstructor>
<code><![CDATA[$id]]></code>
<code><![CDATA[$name]]></code>
</PropertyNotSetInConstructor>
</file>
<file src="tests/Integration/Subscription/Profile.php">
<PropertyNotSetInConstructor>
<code><![CDATA[$id]]></code>
<code><![CDATA[$name]]></code>
</PropertyNotSetInConstructor>
<file src="tests/Unit/EventBus/DefaultEventBusTest.php">
<MoreSpecificImplementedParamType>
<code><![CDATA[$message]]></code>
</MoreSpecificImplementedParamType>
</file>
<file src="tests/Unit/Fixture/MessageNormalizer.php">
<MixedArgumentTypeCoercion>
<code><![CDATA[$value]]></code>
</MixedArgumentTypeCoercion>
</file>
<file src="tests/Unit/Fixture/Order.php">
<PropertyNotSetInConstructor>
<code><![CDATA[$id]]></code>
<code><![CDATA[$orderItems]]></code>
<code><![CDATA[$payment]]></code>
</PropertyNotSetInConstructor>
</file>
<file src="tests/Unit/Fixture/Profile.php">
<PropertyNotSetInConstructor>
<code><![CDATA[$email]]></code>
<code><![CDATA[$id]]></code>
</PropertyNotSetInConstructor>
</file>
<file src="tests/Unit/Fixture/ProfileInvalid.php">
<PropertyNotSetInConstructor>
<code><![CDATA[$email]]></code>
<code><![CDATA[$id]]></code>
</PropertyNotSetInConstructor>
</file>
<file src="tests/Unit/Fixture/ProfileWithBrokenApplyBothUsage.php">
<PropertyNotSetInConstructor>
<code><![CDATA[$id]]></code>
</PropertyNotSetInConstructor>
</file>
<file src="tests/Unit/Fixture/ProfileWithBrokenApplyIntersection.php">
<PropertyNotSetInConstructor>
<code><![CDATA[$id]]></code>
</PropertyNotSetInConstructor>
<ReservedWord>
<code><![CDATA[ProfileCreated&ProfileVisited $event]]></code>
</ReservedWord>
</file>
<file src="tests/Unit/Fixture/ProfileWithBrokenApplyMultipleApply.php">
<PropertyNotSetInConstructor>
<code><![CDATA[$id]]></code>
</PropertyNotSetInConstructor>
</file>
<file src="tests/Unit/Fixture/ProfileWithBrokenApplyNoType.php">
<MissingParamType>
<code><![CDATA[$event]]></code>
</MissingParamType>
<PropertyNotSetInConstructor>
<code><![CDATA[$id]]></code>
</PropertyNotSetInConstructor>
</file>
<file src="tests/Unit/Fixture/ProfileWithEmptyApply.php">
<PropertyNotSetInConstructor>
<code><![CDATA[$id]]></code>
</PropertyNotSetInConstructor>
</file>
<file src="tests/Unit/Fixture/ProfileWithSnapshot.php">
<PropertyNotSetInConstructor>
<code><![CDATA[$email]]></code>
<code><![CDATA[$id]]></code>
<code><![CDATA[$messages]]></code>
</PropertyNotSetInConstructor>
</file>
<file src="tests/Unit/Fixture/ProfileWithSuppressAll.php">
<PropertyNotSetInConstructor>
<code><![CDATA[$id]]></code>
</PropertyNotSetInConstructor>
</file>
<file src="tests/Unit/Fixture/WrongNormalizerBasicAggregate.php">
<PropertyNotSetInConstructor>
<code><![CDATA[$id]]></code>
</PropertyNotSetInConstructor>
</file>
<file src="tests/Unit/Metadata/Subscriber/AttributeSubscriberMetadataFactoryTest.php">
<MissingParamType>
Expand Down
4 changes: 0 additions & 4 deletions tests/Integration/BankAccountSplitStream/Projection/BankAccountProjector.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ public function handleBankAccountCreated(Message $message): void
{
$event = $message->event();

assert($event instanceof BankAccountCreated);

$this->connection->executeStatement(
'INSERT INTO projection_bank_account (id, name, balance_in_cents) VALUES(:id, :name, 0);',
[
Expand All @@ -63,8 +61,6 @@ public function handleBalanceAdded(Message $message): void
{
$event = $message->event();

assert($event instanceof BalanceAdded);

$this->connection->executeStatement(
'UPDATE projection_bank_account SET balance_in_cents = balance_in_cents + :balance WHERE id = :id;',
[
Expand Down

0 comments on commit 900711a

Please sign in to comment.