Update contribution bound and add new 'backstop' bound #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches from per-origin per-day budgets to per-site per-10 min. Also adds a new per-site per-day looser budget as a backstop to prevent worst-case leakage. See original proposal here: #23 (comment)
|
@linnan-github, could you PTAL? Thanks! |
linnan-github
approved these changes
May 17, 2023
linnan-github
approved these changes
May 17, 2023
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 30, 2023
Switches the bound from being per-origin per-day per-API, to per-site per-10 min per-API. Also adds a new per-site per-day per-API looser bound as a backstop to prevent worst-case leakage. The budget data is stored on disk in 1440 separate minute-long windows, replacing the 24 hour-long windows before. We do not use separate stores for the two budgets. This cl also bumps the storage version, which will raze any existing stored budgets. It also updates the data deletion logic to handle the per-site scope, retaining references to the origins that have used it in the last day to support per-origin deletion. (Note that all data for the site will be deleted in case of an origin match, however.) See also patcg-individual-drafts/private-aggregation-api#45 Bug: 1446822 Change-Id: I877a8e6f2e7a8a5b9ea308ee07eadd22112c5416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4543883 Commit-Queue: David Bokan <[email protected]> Reviewed-by: Nan Lin <[email protected]> Reviewed-by: Charlie Harrison <[email protected]> Reviewed-by: David Bokan <[email protected]> Commit-Queue: Alex Turner <[email protected]> Auto-Submit: Alex Turner <[email protected]> Cr-Commit-Position: refs/heads/main@{#1150638}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches from per-origin per-day budgets to per-site per-10 min. Also adds a new per-site per-day looser budget as a backstop to prevent worst-case leakage.
See original proposal here:
#23 (comment)