Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the portion of patches to Private Aggregation that got incorprorated there. #166

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

morlovich
Copy link

@morlovich morlovich commented Oct 22, 2024

@morlovich
Copy link
Author

Hi @alexmturner, could you perhaps review this? It's the mirror of the other change..

@alexmturner
Copy link
Collaborator

Thanks, LGTM!

@alexmturner
Copy link
Collaborator

Unfortunately, this seems to have a couple compiling issues, due to the following not being defined/exported any more:

  • [=interest group/Private Aggregation coordinator=]
  • [=auction config/seller Private Aggregation coordinator=]
  • [=auction config/auction report buyers=]
  • [=auction config/auction report buyer keys=]
  • [=auction config/auction report buyer debug details=]

Maybe we keep these defined in the spec temporarily just to avoid the errors?

It's also complaining about having multiple definitions for:

  • {{AuctionReportBuyersConfig/bucket}}
  • {{AuctionReportBuyersConfig/scale}}

but I think that must just be caching issue? You removed those definitions in this pr...

@morlovich
Copy link
Author

morlovich commented Oct 28, 2024

Huh, did something happen with our auction config/interest group exports? Investigating. I feel like I did do a test build of this before mailing.

Edit: they do have , so either that doesn't work the way I think it does or something else is up?

Anyway, it might be easier to just wait until the entire section is removed.

@alexmturner
Copy link
Collaborator

I think the auction config/interest group pieces were defined in this spec so they didn't need to be exported. But they're still used in the remaining monkey patches. Alternatively, we could modify them to e.g. <a spec="turtledove" for="auction config">auction report buyers</a>, but that seems maybe laborious

@morlovich
Copy link
Author

I think the auction config/interest group pieces were defined in this spec so they didn't need to be exported. But they're still used in the remaining monkey patches. Alternatively, we could modify them to e.g. <a spec="turtledove" for="auction config">auction report buyers</a>, but that seems maybe laborious

Probably not worth the effort since they should be going away shortly.

@alexmturner
Copy link
Collaborator

Yeah, agreed -- probably easiest to just revert the changes under the "Structures" heading for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants