-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the portion of patches to Private Aggregation that got incorprorated there. #166
base: main
Are you sure you want to change the base?
Remove the portion of patches to Private Aggregation that got incorprorated there. #166
Conversation
Hi @alexmturner, could you perhaps review this? It's the mirror of the other change.. |
Thanks, LGTM! |
Unfortunately, this seems to have a couple compiling issues, due to the following not being defined/exported any more:
Maybe we keep these defined in the spec temporarily just to avoid the errors? It's also complaining about having multiple definitions for:
but I think that must just be caching issue? You removed those definitions in this pr... |
Huh, did something happen with our auction config/interest group exports? Investigating. I feel like I did do a test build of this before mailing. Edit: they do have , so either that doesn't work the way I think it does or something else is up? Anyway, it might be easier to just wait until the entire section is removed. |
I think the auction config/interest group pieces were defined in this spec so they didn't need to be exported. But they're still used in the remaining monkey patches. Alternatively, we could modify them to e.g. |
Probably not worth the effort since they should be going away shortly. |
Yeah, agreed -- probably easiest to just revert the changes under the "Structures" heading for now. |
See WICG/turtledove#1297
Preview | Diff