Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose the HTTP port in the service #62

Merged
merged 3 commits into from
Apr 25, 2024
Merged

feat: expose the HTTP port in the service #62

merged 3 commits into from
Apr 25, 2024

Conversation

Kuruyia
Copy link
Contributor

@Kuruyia Kuruyia commented Nov 21, 2023

This modifies the service to also expose the HTTP service. My use case is that, in my cluster, TLS termination is handled by the ingress controller and TLS certificates are managed by cert-manager, so that the application does not have to worry about TLS at all (I think this is a very common setup).

The service key in the values was also updated to allow modifying the port, targetPort and name keys of both the HTTP and HTTPS ports.

This is a breaking change. As this is a change I would very much like to see in upstream, please tell me if something needs to be done about backwards compatibility.

@dlen
Copy link
Member

dlen commented Nov 23, 2023

Hello!

We will be (most likely next month) doing a release 1.0 that will include the breaking changes you suggest in this PR along some other changes. Hope that you can wait a bit more!

Thanks a lot for your contributions, really appreciated!

@Kuruyia
Copy link
Contributor Author

Kuruyia commented Nov 23, 2023

Hi!

I have no problem waiting, I can use my fork in the meantime 😄

Thanks a lot for merging my contributions!

@alexiiiiiiiiiiiiiii
Copy link

Any news about this ? :)

@dlen
Copy link
Member

dlen commented Feb 5, 2024

Hey, thanks for the interest, we'll probably release this, with all the other breaking changes and create a v1.0 of the chart in a couple of weeks. Thanks for your patience!

@Xhelliom
Copy link

Hello :)
Any information of when the 1.0 of the chart will be release ?
Thanks in advance and thank you for your good work 🥇

@dlen
Copy link
Member

dlen commented Mar 18, 2024

Hello @Xhelliom! Thanks for the kind words! ❤️

We are planning to work on the chart in a couple of weeks, our bandwidth is a bit limited so bear with us :)

@MariiAnet
Copy link

Hi!

Any news about the chart release?

@dlen
Copy link
Member

dlen commented Apr 19, 2024

Hello!

Yes, we have been working on it this last few days and next week it will be out as a release candidate for people to test as it contains few breaking changes.

@dlen dlen merged commit 42e473d into passbolt:main Apr 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants