feat: expose the HTTP port in the service #62
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the service to also expose the HTTP service. My use case is that, in my cluster, TLS termination is handled by the ingress controller and TLS certificates are managed by cert-manager, so that the application does not have to worry about TLS at all (I think this is a very common setup).
The
service
key in the values was also updated to allow modifying theport
,targetPort
andname
keys of both the HTTP and HTTPS ports.This is a breaking change. As this is a change I would very much like to see in upstream, please tell me if something needs to be done about backwards compatibility.