use the same empty string comparison through out the code

pashagolub · Oct 18, 2023 · 3c52e8d · 3c52e8d
1 parent 1ff4542
commit 3c52e8d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/expectations.go b/expectations.go
@@ -246,7 +246,7 @@ func (e *ExpectedExec) String() string {
 			msg += fmt.Sprintf("\t\t%d - %+v\n", i, arg)
 		}
 	}
-	if e.result.String() > "" {
+	if e.result.String() != "" {
 		msg += fmt.Sprintf("\t- returns result: %s\n", e.result)
 	}
 

diff --git a/pgxmock.go b/pgxmock.go
@@ -434,7 +434,7 @@ func (c *pgxmock) Query(ctx context.Context, sql string, args ...interface{}) (p
 		}
 		if rewrittenSQL, err := queryExp.argsMatches(sql, args); err != nil {
 			return err
-		} else if rewrittenSQL > "" {
+		} else if rewrittenSQL != "" {
 			if err := c.queryMatcher.Match(queryExp.expectRewrittenSQL, rewrittenSQL); err != nil {
 				return err
 			}
@@ -474,7 +474,7 @@ func (c *pgxmock) Exec(ctx context.Context, query string, args ...interface{}) (
 		}
 		if rewrittenSQL, err := execExp.argsMatches(query, args); err != nil {
 			return err
-		} else if rewrittenSQL > "" {
+		} else if rewrittenSQL != "" {
 			if err := c.queryMatcher.Match(execExp.expectRewrittenSQL, rewrittenSQL); err != nil {
 				//pgx support QueryRewriter for arguments, now we can check if the query was actually rewriten
 				return err