Fixes #32

Also added regression e2e test
parttio · May 3, 2024 · 96f0591 · 96f0591
1 parent 05766b6
commit 96f0591
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 11 deletions.
diff --git a/src/main/java/org/vaadin/tinymce/TinyMce.java b/src/main/java/org/vaadin/tinymce/TinyMce.java
@@ -37,7 +37,9 @@
 import elemental.json.JsonObject;
 import elemental.json.JsonValue;
 
+import java.util.Arrays;
 import java.util.UUID;
+import java.util.stream.Collectors;
 
 /**
  * A Rich Text editor, based on TinyMCE Web Component.
@@ -354,21 +356,17 @@ public TinyMce configureMenubar(boolean basicTinyMCE, Menubar... menubars) {
             createBasicTinyMce();
         }
 
-        JsonArray jsonArray = config.get("menubar");
-        int initialIndex = 0;
+        String newconfig  = Arrays.stream(menubars).map(m -> m.menubarLabel).collect(Collectors.joining(" "));
 
-        if (jsonArray != null) {
-            initialIndex = jsonArray.length();
+        String menubar;
+        if (config.hasKey("menubar")) {
+            menubar = config.getString("menubar");
+            menubar = menubar + " " + newconfig;
         } else {
-            jsonArray = Json.createArray();
-        }
-
-        for (int i = 0; i < menubars.length; i++) {
-            jsonArray.set(initialIndex, menubars[i].menubarLabel);
-            initialIndex++;
+            menubar = newconfig;
         }
 
-        config.put("menubar", jsonArray);
+        config.put("menubar", menubar);
         return this;
     }
 

diff --git a/src/test/java/org/vaadin/tinymce/MopoSmokeTest.java b/src/test/java/org/vaadin/tinymce/MopoSmokeTest.java
@@ -4,8 +4,10 @@
 import com.microsoft.playwright.BrowserType;
 import com.microsoft.playwright.Page;
 import com.microsoft.playwright.Playwright;
+import com.microsoft.playwright.assertions.PlaywrightAssertions;
 import in.virit.mopo.Mopo;
 import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.springframework.boot.test.context.SpringBootTest;
@@ -53,4 +55,13 @@ public void smokeTest() {
         });
 
     }
+
+    @Test
+    public void menuConfig() throws InterruptedException {
+        String url = "http://localhost:" + port + "/menuconfig";
+        page.navigate(url);
+        PlaywrightAssertions.assertThat(page.locator("button").getByText("File")).isVisible();
+        Assertions.assertEquals(0, page.locator("button").getByText("Insert").count());
+    }
+
 }