Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaadin 24.4.1 compatibility #73

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Vaadin 24.4.1 compatibility #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a408c2
Vaadin 24.4.1 compatibility
Jul 2, 2024
28e7669
Vaadin 24.4.1 compatibility, commented out code has removed
Jul 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ This is an awesome TextField formatter extension built on top [Cleave.js](https:
Supports credit card formatting and custom blocks e.g. IBAN.

# Builds
### Vaadin 24 (5.5.0 branch)

### Vaadin 14 (master)
[![Build Status](https://travis-ci.org/johannesh2/textfieldformatter.svg?branch=master)](https://travis-ci.org/johannesh2/textfieldformatter)

Expand Down
48 changes: 48 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
<modelVersion>4.0.0</modelVersion>
<groupId>org.vaadin</groupId>
<artifactId>textfieldformatter</artifactId>
<version>5.5-SNAPSHOT</version>
<version>5.5.0-SNAPSHOT</version>
<name>TextField Formatter</name>
<packaging>jar</packaging>
<organization>
<name>Community</name>
</organization>
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<vaadin.version>14.8.4</vaadin.version>
<vaadin.version>24.4.1</vaadin.version>
<vaadin.plugin.version>${vaadin.version}</vaadin.plugin.version>
<!-- ZIP Manifest fields -->
<Implementation-Version>${project.version}</Implementation-Version>
Expand Down
5 changes: 1 addition & 4 deletions src/test/java/org/vaadin/textfieldformatter/MainView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,8 @@
import com.vaadin.flow.router.RouteData;
import com.vaadin.flow.router.RouterLayout;
import com.vaadin.flow.router.RouterLink;
import com.vaadin.flow.theme.Theme;
import com.vaadin.flow.theme.lumo.Lumo;

@Route
@Theme(Lumo.class)
public class MainView extends HorizontalLayout implements RouterLayout {

private VerticalLayout menu;
Expand All @@ -40,7 +37,7 @@ public MainView() {
menu.add(link);
}
} else {
menu.add(new RouterLink(route.getUrl(), route.getNavigationTarget()));
menu.add(new RouterLink(route.getNavigationTarget()));
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/vaadin/textfieldformatter/it/AbstractCustomTestBenchTestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ protected void startBrowser(WebDriver driver) {
ChromeOptions opt = new ChromeOptions();
String headless = System.getProperty("test.headless");
if (headless != null && Boolean.valueOf(headless)) {
opt.setHeadless(true);
opt.addArguments("--headless=new");
}
driver = new ChromeDriver(opt);
setDriver(driver);
Expand Down