Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't autosearch octo for empty name #1172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

h0m3us3r
Copy link

@h0m3us3r h0m3us3r commented Jan 1, 2021

TL;DR: Save OctoPart API credits by not auto-searching for empty names.

Currently, when the "Octopart..." button is pressed in the "Add Part" window, an automatic query is performed with the value of the "Name" field. This happens even if the user haven't inputted anything into the "Name" field yet, most likely with the intention of doing it in the "Octopart Search" window itself. This effectively wastes the partkeepr.octopart.limit number of credits on running an effectively useless query. Changes in this PR prevent auto-running empty queries (but do not prevent one from manually running them from the "Octopart Search" window itself by pressing "Enter" in case one might for some weird reason desire to).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant