WIP: DataCollection/StateDescriptor niceties #923
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically adds a couple of convenience functions to the interface changes in #921, which I find useful in KHARMA. Not terribly relevant to the real content of that PR so I'm posting it separately.
Depends on #907 (at least as posted here, to prevent merge conflicts later)
Basically this adds a lot of overloads to the
DataCollection::Add()
function, which allow it to take strings denoting a particularMeshData
to copy from, and making it default to copying from "base." I find both conventions much more readable, and I think they might be easier for newcomers to the code to understand given that allocations andAdd
calls are some of the first things one runs into trying to read/understand KHARMA.It also adds a function
GetPackDimension
toStateDescriptor
which returns the length of a theoretical pack of variables from that package given aFlagCollection
. This is useful for allocating variables of the full pack length (fluxes, boundaries, etc.) beforeMesh
initialization.PR Checklist