Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Gaussian quadrature #875

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

WIP: Gaussian quadrature #875

wants to merge 8 commits into from

Conversation

BenWibking
Copy link
Collaborator

PR Summary

This adds Gaussian quadrature with a fixed number of nodes. This is just a Kokkos-ized version of the Boost::math implementation.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool! But it strikes me as a mighty big hammer, as this implementation is very general.

src/utils/gauss_quad.hpp Outdated Show resolved Hide resolved
src/utils/gauss_quad.hpp Outdated Show resolved Hide resolved
src/utils/gauss_quad.hpp Outdated Show resolved Hide resolved
src/utils/gauss_quad.hpp Outdated Show resolved Hide resolved
src/utils/gauss_quad.hpp Outdated Show resolved Hide resolved
src/utils/gauss_quad.hpp Outdated Show resolved Hide resolved
src/utils/gauss_quad.hpp Outdated Show resolved Hide resolved
@BenWibking
Copy link
Collaborator Author

@Yurlungur Can you re-review this PR?

I assume Catch tests are also needed. Let me know what scope of tests would be appropriate for this.

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all my changes! Yeah, some catch2 tests would be good. Maybe integration of a polynomial of the correct order, and showing that the gauss quadratrue gets it exactly on both host and device would be good? e.g., if you use 7th order gauss quadrature, you should be able to integrate a 6th(? might be getting the appropriate order wrong) order polynomial exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants