-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Gaussian quadrature #875
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool! But it strikes me as a mighty big hammer, as this implementation is very general.
Co-authored-by: Jonah Miller <[email protected]>
@Yurlungur Can you re-review this PR? I assume Catch tests are also needed. Let me know what scope of tests would be appropriate for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all my changes! Yeah, some catch2 tests would be good. Maybe integration of a polynomial of the correct order, and showing that the gauss quadratrue gets it exactly on both host and device would be good? e.g., if you use 7th order gauss quadrature, you should be able to integrate a 6th(? might be getting the appropriate order wrong) order polynomial exactly.
PR Summary
This adds Gaussian quadrature with a fixed number of nodes. This is just a Kokkos-ized version of the Boost::math implementation.
PR Checklist