Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This moves the
t
,u
andv
indices of the kernel inSetBounds
to the outer loop from their current spot in the inner loop. This will help to launch enough teams via the outer loop in codes with a single variable and single block per rank, where the total number of boundary buffers on a rank may be quite small.Because all the indices are abstracted, one could imagine using basically this code to instead specify a desired number of teams, or amount of work per team -- the additional flexibility might let a broader range of codes realize a little speedup.
PR Checklist