Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small: Changes to DataCollection::Add and MeshBlockData::Intialize #1187

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

lroberts36
Copy link
Collaborator

@lroberts36 lroberts36 commented Oct 10, 2024

PR Summary

This PR does two related things:

  1. It adds a check in DataCollection::Add that if a container already exists, it was created with the exact same list of fields as were passed into the current call to Add. Previously, it was just checked that the pre-existing container had a superset of the requested fields, which lead to a communication bug in multigrid that took me a long time to figure out.
  2. Adds the ability to call DataCollection::Add on a partition with a list of fields to include. Previously, this resulted in a PARTHENON_FAIL.

I am open to arguments on 1) why this isn't the behavior we desire.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@lroberts36 lroberts36 changed the title Changes to DataCollection::Add and MeshBlockData::Intialize Small: Changes to DataCollection::Add and MeshBlockData::Intialize Oct 10, 2024
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lroberts36 lroberts36 merged commit 1e77c13 into develop Oct 14, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants