Small: Changes to DataCollection::Add
and MeshBlockData::Intialize
#1187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR does two related things:
DataCollection::Add
that if a container already exists, it was created with the exact same list of fields as were passed into the current call toAdd
. Previously, it was just checked that the pre-existing container had a superset of the requested fields, which lead to a communication bug in multigrid that took me a long time to figure out.DataCollection::Add
on a partition with a list of fields to include. Previously, this resulted in aPARTHENON_FAIL
.I am open to arguments on 1) why this isn't the behavior we desire.
PR Checklist