Fix bug in static refinement #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yurlungur
reviewed
May 9, 2024
|
Agreed, we need to add a couple tests that use multi-tree forests. We have at least one that uses SMR, but the bug does not manifest if the base grid only requires one tree. |
lroberts36
changed the title
Yurlungur
approved these changes
May 14, 2024
lroberts36
changed the base branch from
develop
to
lroberts36/fix-restart-state-bug
pgrete
approved these changes
May 15, 2024
| + "/tst/regression/gold_standard/sparse_twotree.out0.final.phdf", | ||
| ], | ||
| one=True, | ||
| tol=1e-12, |
There was a problem hiding this comment.
Any reason for the "loose" tolerance?
There was a problem hiding this comment.
I think I just copied this tolerance from the other checks. Isn't 1.e-12 what we set for most tests? I don't think this test should be bitwise exact between machines.
tst/regression/test_suites/sparse_advection/sparse_advection.py
Outdated
Show resolved
Hide resolved
lroberts36
changed the base branch from
lroberts36/fix-restart-state-bug
to
develop
lroberts36
changed the base branch from
develop
to
lroberts36/fix-restart-state-bug
lroberts36
changed the base branch from
lroberts36/fix-restart-state-bug
to
develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The re-definition of
Mesh::root_levelintroduced in #1053 did not get correctly propagated through the static refinement related code (which operates on logical locations relative to the legacy tree). This PR fixes that issue, which had cropped up in Artemis.PR Checklist