-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add OpenPMD support #1050
base: develop
Are you sure you want to change the base?
WIP: Add OpenPMD support #1050
Conversation
src/outputs/openpmd.cpp
Outdated
for (auto &pmb : pm->block_list) { | ||
// TODO(pgrete) check if we should skip the suffix for level 0 | ||
const auto level = pmb->loc.level() - pm->GetRootLevel(); | ||
const std::string &mesh_record_name = var_name + "_lvl" + std::to_string(level); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Writing level
src/outputs/restart_opmd.cpp
Outdated
for (auto &pmb : pm->block_list) { | ||
// TODO(pgrete) check if we should skip the suffix for level 0 | ||
// TODO(pgrete) ask LR why this is not mirrored from writing | ||
// const auto level = pmb->loc.level() - pm->GetRootLevel(); | ||
const auto level = pmb->loc.level(); | ||
const std::string &mesh_record_name = var_name + "_lvl" + std::to_string(level); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading level
Ok, that makes sense, but I think there's a risk this will be significantly delayed if this is blocked on a > 1 yr old PR in openPMD. |
I am unable to read the outputs this produces with Paraview. Has anyone else been able to do so? Details: https://discourse.paraview.org/t/no-fields-are-rendered-after-opening-openpmd-file/15533 |
In case anyone else encounters this, the files load fine using the ADIOS2 image reader in Paraview, but not with the OpenPMD-api reader: https://openpmd-api.readthedocs.io/en/latest/analysis/paraview.html#openpmd |
This PR is now broken due to changes in #1177:
@Yurlungur is there an easy fix for this? |
Yes, I'll take care of it. |
Done. |
PR Summary
PR Checklist