Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particle BCs without relocatable device code #1026

Merged
merged 68 commits into from
May 14, 2024

Conversation

brryan
Copy link
Collaborator

@brryan brryan commented Mar 17, 2024

PR Summary

Particles currently use relocatable device code via inheritance to provide boundary condition functions on a per-particle basis. This PR moves to boundary conditions on particles via kernel launches in a manner analogous to field boundary conditions.

Breaking: completely new particle BCs for downstream codes doing custom implementations.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files
  • Merge Forest Of Octrees #1009
  • Fix particle tracers bug (missing dependence for Defrag task)
  • Add particle_tracers example to CI

@brryan brryan changed the base branch from lroberts36/add-forest-of-octrees to develop April 26, 2024 01:33
@brryan brryan requested a review from pgrete May 8, 2024 20:06
@lroberts36
Copy link
Collaborator

@brryan: ok, that makes sense. I was just going to try and start seeing what is required to merge this with the mesh constructor refactor PR and the forest PR that is currently in WIP.

@pgrete
Copy link
Collaborator

pgrete commented May 9, 2024

As for the SwarmPacks I'm happy with the discussion and don't plan a detailed review. So just go ahead an merge when everyone is happy.

@brryan
Copy link
Collaborator Author

brryan commented May 13, 2024

I verified that this works downstream, including custom reflecting BCs for particles, so I'm enabling auto-merge now. Thanks everyone for reviews

@brryan brryan enabled auto-merge (squash) May 13, 2024 16:39
@brryan brryan disabled auto-merge May 13, 2024 19:34
@brryan brryan enabled auto-merge (squash) May 13, 2024 19:34
@brryan brryan disabled auto-merge May 13, 2024 19:42
@brryan brryan enabled auto-merge (squash) May 13, 2024 19:43
@lroberts36 lroberts36 disabled auto-merge May 14, 2024 00:19
@lroberts36 lroberts36 enabled auto-merge May 14, 2024 00:19
@lroberts36 lroberts36 merged commit 4049c6f into develop May 14, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants