fix initialization

parthenon-hpc-lab · Jul 10, 2024 · a2c89bf · a2c89bf
1 parent 1398a5c
commit a2c89bf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/src/mesh/forest/forest_node.hpp b/src/mesh/forest/forest_node.hpp
@@ -32,7 +32,7 @@ namespace forest {
 class Face;
 class Node {
  public:
-  Node(int id_in, std::array<Real, NDIM> pos) : id(id_in), x(pos) {}
+  Node(int id_in, std::array<Real, NDIM> pos) : id(id_in), x(pos), associated_faces{} {}
 
   static std::shared_ptr<Node> create(int id, std::array<Real, NDIM> pos) {
     return std::make_shared<Node>(id, pos);

diff --git a/src/mesh/forest/forest_topology.hpp b/src/mesh/forest/forest_topology.hpp
@@ -49,15 +49,9 @@ class Edge {
   Edge(sptr_vec_t<Node, 2> nodes_in, const CellCentOffsets &ploc)
       : nodes{nodes_in}, loc{ploc} {
     PARTHENON_REQUIRE(loc->IsEdge(), "Trying to pass a non-edge location to an edge.");
-    auto dirs = loc->GetTangentDirections();
-    dir = dirs[0];
-    auto ndirs = loc->GetNormals();
-    normals = {ndirs[0], ndirs[1]};
   }
 
   sptr_vec_t<Node, 2> nodes;
-  CoordinateDirection dir;
-  std::array<std::pair<CoordinateDirection, Offset>, 2> normals;
   std::optional<CellCentOffsets> loc{};
 
   int RelativeOrientation(const Edge &e2) const {
@@ -116,7 +110,7 @@ class Face : public std::enable_shared_from_this<Face> {
 
   std::shared_ptr<Face> getptr() { return shared_from_this(); }
 
-  std::int64_t my_id;
+  std::int64_t my_id{-1};
 
   sptr_vec_t<Node, 4> nodes;
   std::unordered_map<std::shared_ptr<Node>, int> face_index;