Add isotropic viscosity and resistivity #89
Conversation
…or using prolong/restric with non-base containers)
pgrete
force-pushed
the
pgrete/diffusion
branch
2 times, most recently
from
35a3579 to
10281a1
Compare
pgrete
force-pushed
the
pgrete/diffusion
branch
from
10281a1 to
98f2f1f
Compare
pgrete
changed the title
docs/input.md
Outdated
| <diffusion> | ||
| integrator = unsplit # alternatively: rkl2 | ||
| #rkl2_max_dt_ratio = 100.0 # limits the ratio between the parabolic and hyperbolic timesteps | ||
| #cfl = 1.0 # Additional safety factor applied to diffusive timestep constraint. Default to hyperbolic cfl. |
There was a problem hiding this comment.
again, for rkl2/operator split integrator (the main point here is that there are a lot of knobs to turn and it'd help to avoid confusion in this regard)
There was a problem hiding this comment.
Actually this applies to both. I adjusted the comment accordingly.
docs/input.md
Outdated
|
|
||
| conduction = anisotropic # none (disabled), or isotropic, or anisotropic | ||
| conduction_coeff = fixed # alternative: spitzer | ||
| thermal_diff_coeff_code = 0.01 # fixed coefficent in code units |
There was a problem hiding this comment.
A general comment about coefficients - based on conversations with my current grad students, they would really appreciate if the units of the viscosity and resistivity were mentioned in the documentation, and perhaps a reference (even to a Shu or Spitzer textbook section) where they can figure out some details about the physics so they can set numbers appropriately.
There was a problem hiding this comment.
I just added the info on the units itself.
Regarding text book references, I'm happy if any student who does a deep dive intro opens a PR to extend the documentation accordingly.
docs/input.md
Outdated
| #### Viscosity/Momentum diffusion | ||
|
|
||
| Only isotropic viscosity with a (spatially and temporally) fixed coefficient in code units | ||
| is currently implemented. |
There was a problem hiding this comment.
this would be a helpful place to mention the units of viscosity, even if it's only available in code units (this would help students who are trying to figure out what values are reasonable based on other simulation settings). Same thing applies for the resistivity subsection below.
There was a problem hiding this comment.
Added info both here and in the overview block above.
tst/regression/test_suites/diffusion_linwave3d/diffusion_linwave3d.py
Outdated
Show resolved
Hide resolved
What is says on the can: adds support for isotropic viscosity and resistivity
Description on usage and implementation part of the PR itself (so won't repeat here).
The artifacts from the new regression tests are for the viscosity
and for the resistivity
Should be ready for review and comments.