#413: Add test to DefUntil to test the list semantics. #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test shows how multiple values for initialSize, stepSize and maxSize are used together and which offsets in which order are used to parse the terminator.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #414 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 1150 1150
===========================================
Files 98 98
Lines 1537 1537
Branches 159 159
===========================================
Hits 1537 1537 ☔ View full report in Codecov by Sentry. |
|
Because I simply added a test, decided to merge it without any reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test shows how multiple values for initialSize, stepSize and maxSize are used together and which offsets in which order are used to parse the terminator.
This was missing in our test base. We had 100% test coverage, because also with single values, we process them as lists. Clear example that line coverage is not the same as test coverage. ;)