Test all constructors that do not contain generics in AutoEqualityTest. #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jvdb <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #409 +/- ##
=============================================
+ Coverage 92.31% 100.00% +7.68%
- Complexity 1014 1153 +139
=============================================
Files 99 99
Lines 1536 1536
Branches 157 157
=============================================
+ Hits 1418 1536 +118
+ Misses 89 0 -89
+ Partials 29 0 -29 ☔ View full report in Codecov by Sentry. |
rdvdijk
approved these changes
Feb 8, 2024
| } | ||
| args.add(mapping.get(cl)); | ||
| } | ||
| List<List<Supplier<Object>>> argLists = generateCombinations(0, args); |
| } | ||
| List<List<Supplier<Object>>> argLists = generateCombinations(0, args); | ||
| List<Object> otherInstances = new ArrayList<>(); | ||
| for (List<Supplier<Object>> argList : argLists.subList(1, argLists.size())) { |
There was a problem hiding this comment.
Another missing final here.
Suggested change
| for (List<Supplier<Object>> argList : argLists.subList(1, argLists.size())) { | |
| for (final List<Supplier<Object>> argList : argLists.subList(1, argLists.size())) { |
Co-authored-by: jvdb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, het mysterie is ontrafelt!
GitHub: Je build is groen!
Codecov: Maar geen 100% coverage, je mist equality checks!
IntelliJ: Onzin! Die worden gewoon gecheckt! 100%, behalve dan de Source interface.
CodeCov: Source interface? Die wordt veelvuldig gebruikt en getest waar heb je het over? Die equalities zijn het probleem!
IntelliJ: AutoEqualityTest runt gewoon volledig! Ik snap niet waar je het over hebt! Waarom denk jij dat ze missen?
CodeCov: Weet ik veel! Ze missen gewoon!
que Maven
Maven: Oh, releasen?! Nee, je AutoEqualityTest faalt... Je moet een mapping toevoegen voor Map object.
CodeCov: Ha!
IntelliJ: Huh? Maar de build is groen?!
GitHub: Laat mij erbuiten!
IntelliJ: En ik heb helemaal geen Map object nodig om de volledig test te kunnen runnen. Java geeft mij geen enkele constructor terug met een Map parameter!
que Java
Java: You called?
IntelliJ: Welke constructors ben je wanneer aan het geven?
Java: Oh, gewoon in een volgorde die ik leuk vind!
IntelliJ: ...
Java: Niet goed?
CodeCov: Ik heb dus gelijk dat equality checks missen! :D
IntelliJ: Je kon alleen niet zeggen waarom!
CodeCov: Dat is mijn werk niet!
IntelliJ: ...
THE END
Let's get our 100% coverage back!