Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade deps #950

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Upgrade deps #950

merged 3 commits into from
Oct 3, 2024

Conversation

parmesant
Copy link
Contributor

closes #949

Description

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@parmesant parmesant force-pushed the upgrade-deps branch 2 times, most recently from dad3fe3 to ebd1038 Compare October 1, 2024 06:33
@nitisht nitisht marked this pull request as ready for review October 1, 2024 10:57
nikhilsinhaparseable
nikhilsinhaparseable previously approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

nitisht
nitisht reviewed Oct 2, 2024
View reviewed changes
server/Cargo.toml Outdated Show resolved Hide resolved
server/Cargo.toml Outdated Show resolved Hide resolved
server/src/cli.rs Show resolved Hide resolved
server/src/query.rs Show resolved Hide resolved
@nitisht nitisht mentioned this pull request Oct 3, 2024
Closed
@parmesant parmesant force-pushed the upgrade-deps branch 2 times, most recently from a8726bc to 13a661b Compare October 3, 2024 07:16
@nitisht nitisht merged commit 2dbb0a8 into parseablehq:main Oct 3, 2024
8 checks passed
@parmesant parmesant deleted the upgrade-deps branch October 3, 2024 10:05
parmesant added a commit to parmesant/parseable that referenced this pull request Oct 3, 2024
@parmesant
feat: upgrade dependencies (parseablehq#950)
4e1279f 
also update row group size
parmesant added a commit to parmesant/parseable that referenced this pull request Oct 3, 2024
@parmesant
feat: upgrade dependencies (parseablehq#950)
8119e9f 
also update row group size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitisht nitisht nitisht left review comments

@nikhilsinhaparseable nikhilsinhaparseable Awaiting requested review from nikhilsinhaparseable

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade dependencies
3 participants
@parmesant @nitisht @nikhilsinhaparseable