Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provide parent data when resolving with cloud function #8795

Open
wants to merge 2 commits into
base: release-5.x.x
Choose a base branch
from

Conversation

bschulz87
Copy link

Pull Request

Issue

Closes: 7621

@parse-github-assistant
Copy link

Thanks for opening this pull request!

@bschulz87 bschulz87 changed the title Provide parent data when resolving with cloud function feat: Provide parent data when resolving with cloud function Oct 27, 2023
@mtrezza
Copy link
Member

mtrezza commented Oct 28, 2023

Could you add a test for this new feature?

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c4a4a2a) 94.10% compared to head (0a54b95) 94.09%.
Report is 1 commits behind head on release-5.x.x.

❗ Current head 0a54b95 differs from pull request most recent head c23fcb4. Consider uploading reports for the commit c23fcb4 to get more accurate results

Additional details and impacted files
@@                Coverage Diff                @@
##           release-5.x.x    #8795      +/-   ##
=================================================
- Coverage          94.10%   94.09%   -0.01%     
=================================================
  Files                184      184              
  Lines              13814    13813       -1     
=================================================
- Hits               12999    12997       -2     
- Misses               815      816       +1     
Files Coverage Δ
src/GraphQL/loaders/schemaDirectives.js 96.00% <ø> (ø)
src/Routers/FunctionsRouter.js 94.02% <100.00%> (-0.09%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bschulz87
Copy link
Author

bschulz87 commented Oct 29, 2023

Well, i would add a test which confirms the presence of parent data but i don't know how to get started. The test script (npm run test= won't start on my machine: Starting a MongoDB deployment to test against...Error: Could not figure out current Linux distro (Arch, arch)

Edit: I managed to build the parse-server docker image and started a mongodb in a container but the test won't start in my environment. When omitting the pretest script it starts but the suite has timeout errors.

@mtrezza
Copy link
Member

mtrezza commented Oct 29, 2023

We have a blog article that is especially directed towards first time contributors and a more technical Contribution Guide to help you get started with setting up a test environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants