Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add default acl #8701

Open
wants to merge 6 commits into
base: alpha
Choose a base branch
from
Open

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Jul 24, 2023

Pull Request

Issue

Closes: #7068

Approach

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: add default acl feat: Add default acl Jul 24, 2023
@parse-github-assistant
Copy link

Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 84.21% and no project coverage change.

Comparison is base (6a4a00c) 94.37% compared to head (41aa6d6) 94.37%.
Report is 1 commits behind head on alpha.

❗ Current head 41aa6d6 differs from pull request most recent head 68bc76a. Consider uploading reports for the commit 68bc76a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #8701   +/-   ##
=======================================
  Coverage   94.37%   94.37%           
=======================================
  Files         185      185           
  Lines       14761    14779   +18     
=======================================
+ Hits        13930    13948   +18     
  Misses        831      831           
Files Changed Coverage Δ
...rc/Adapters/Storage/Mongo/MongoSchemaCollection.js 97.84% <ø> (ø)
...dapters/Storage/Postgres/PostgresStorageAdapter.js 95.74% <ø> (ø)
src/Controllers/SchemaController.js 96.98% <70.00%> (-0.50%) ⬇️
src/RestWrite.js 95.08% <100.00%> (+0.21%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblythy dblythy requested a review from a team July 27, 2023 16:06
@mtrezza
Copy link
Member

mtrezza commented Jul 28, 2023

Could you add a more detailed description about what this PR does? The issue discussion is rather open and doesn't really spell out a specific approach.

  • It this a breaking change?
  • What does it change? We should probably add more details to the changelog entry for that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow option to set Default ACL
2 participants