Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add support for Xcode 16 #1818

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Oct 30, 2024

New Pull Request Checklist

Issue Description

CI is currently not testing with Xcode 16.

Closes: #1812
Closes: #1799

Approach

  • Add Xcode 16 to CI tests.
  • Bump Ruby to 3.1 (for sqllite with native extensions)
  • Bump Bundler to 2.5.22
  • Pin gemfile
  • Improve ruby/bundler cache

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • Update GitHub CI to new job names

Copy link

parse-github-assistant bot commented Oct 30, 2024

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.80%. Comparing base (dd05d41) to head (43cf333).
Report is 28 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1818       +/-   ##
===========================================
+ Coverage   64.24%   82.80%   +18.56%     
===========================================
  Files         201      282       +81     
  Lines       23233    30726     +7493     
===========================================
+ Hits        14926    25443    +10517     
+ Misses       8307     5283     -3024     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dplewis dplewis requested a review from a team October 30, 2024 14:10
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! What happened to the tests (build:starters) though?

@dplewis
Copy link
Member Author

dplewis commented Oct 30, 2024

Xcode 14, 15, 16 runs build:starters

@mtrezza
Copy link
Member

mtrezza commented Oct 30, 2024

Oh, now I saw it in the changes. I'll add that to the TODOs

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit 0be6870 into parse-community:master Oct 30, 2024
11 checks passed
@mtrezza
Copy link
Member

mtrezza commented Oct 30, 2024

I feel like this deserves a changelog entry. Normally, when we add support for a platform version, we have a changelog entry, but the README does not state any specific IDE or OS compatibility. It says iOS 12 for example, but what should that mean?

@dplewis dplewis deleted the xcode-16 branch October 30, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Xcode 16 to CI tests
2 participants