Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Compilation errors Undefined symbol and SystemConfiguration not found on watchOS #1748

Merged
merged 9 commits into from
Oct 5, 2023

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Oct 5, 2023

New Pull Request Checklist

Issue Description

Building the framework against watchOS starter project won't build

  • Undefined symbol OBJC_CLASS$_PFInstallation
  • Undefined symbol OBJC_CLASS$_PFPush
  • SystemConfiguration not found

Closes: #1746
Closes: #1743

Approach

  • Stub out incompatible files
  • Run watchOS starter project in CI
  • Properly handle local project via SPM

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 5, 2023

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9fda428) 63.44% compared to head (b953863) 64.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1748      +/-   ##
==========================================
+ Coverage   63.44%   64.43%   +0.98%     
==========================================
  Files         192      200       +8     
  Lines       22524    23177     +653     
==========================================
+ Hits        14291    14933     +642     
- Misses       8233     8244      +11     
Files Coverage Δ
...Installation/Controller/PFInstallationController.m 0.00% <ø> (ø)
...lationController/PFCurrentInstallationController.m 69.64% <ø> (ø)
Parse/Parse/Internal/PFReachability.m 80.50% <ø> (ø)
...rse/Parse/Internal/Push/Utilites/PFPushUtilities.m 47.61% <ø> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dplewis
Copy link
Member Author

dplewis commented Oct 5, 2023

The starter projects work locally for me. I updated the starter projects on Xcode 15 and macOS 17, M1 Chip. I'll do more investigation on why it's failing

@dplewis
Copy link
Member Author

dplewis commented Oct 5, 2023

@mtrezza This is ready for merge.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

.github/workflows/ci.yml Show resolved Hide resolved
@mtrezza mtrezza changed the title fix: Compilation errors on watchOS fix: Compilation errors Undefined symbol and SystemConfiguration not found on watchOS Oct 5, 2023
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit e7df36b into parse-community:master Oct 5, 2023
12 checks passed
@dplewis dplewis deleted the watchos-fix branch October 5, 2023 22:16
parseplatformorg pushed a commit that referenced this pull request Oct 5, 2023
## [2.7.2](2.7.1...2.7.2) (2023-10-05)

### Bug Fixes

* Compilation errors `Undefined symbol` and `SystemConfiguration not found` on watchOS ([#1748](#1748)) ([e7df36b](e7df36b))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 2.7.2

@parseplatformorg parseplatformorg added the state:released Released as stable version label Oct 5, 2023
eeallen1 added a commit to eeallen1/Parse-SDK-iOS-OSX that referenced this pull request May 6, 2024
* commit 'ef9b00de9eeeca7fddfe9439141f5141ff5dac02': (86 commits)
  chore(release): 3.0.0 [skip ci]
  ci: Fix release workflow (parse-community#1782)
  feat: Remove `ParseFacebookUtils` and `ParseTwitterUtils` (parse-community#1779)
  feat: Add `PFObject.isDataAvailableForKey` to check if data is available for individual key (parse-community#1756)
  ci: Bump ip from 2.0.0 to 2.0.1 (parse-community#1772)
  ci: Fix failing CI by pinning bundler version (parse-community#1778)
  refactor: Remove Carthage dependency (parse-community#1763)
  refactor: Remove OCMock Carthage dependency (parse-community#1754)
  ci: Run CI on Xcode 15 and macOS 13 (parse-community#1753)
  refactor: Update ruby dependencies (parse-community#1752)
  refactor: Remove framework builder for assets (parse-community#1751)
  chore(release): 2.7.3 [skip ci]
  fix: Compilation errors in `ParseLiveQuery` using `Starscream` 4.0.6 (parse-community#1749)
  docs: Add changelog note about missing assets (parse-community#1750)
  chore(release): 2.7.2 [skip ci]
  fix: Compilation errors `Undefined symbol` and `SystemConfiguration not found` on watchOS (parse-community#1748)
  ci: Remove publishing release assets (parse-community#1745)
  ci: Fix and build Starter Projects (parse-community#1744)
  chore(release): 2.7.1 [skip ci]
  fix: Compilation error on macOS `Undefined symbol: OBJC_CLASS$_PFProductsRequestHandler` (parse-community#1739)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version
Projects
None yet
3 participants