-
-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Compilation errors Undefined symbol
and SystemConfiguration not found
on watchOS
#1748
Conversation
Thanks for opening this pull request!
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1748 +/- ##
==========================================
+ Coverage 63.44% 64.43% +0.98%
==========================================
Files 192 200 +8
Lines 22524 23177 +653
==========================================
+ Hits 14291 14933 +642
- Misses 8233 8244 +11
☔ View full report in Codecov by Sentry. |
The starter projects work locally for me. I updated the starter projects on Xcode 15 and macOS 17, M1 Chip. I'll do more investigation on why it's failing |
@mtrezza This is ready for merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
Undefined symbol
and SystemConfiguration not found
on watchOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
## [2.7.2](2.7.1...2.7.2) (2023-10-05) ### Bug Fixes * Compilation errors `Undefined symbol` and `SystemConfiguration not found` on watchOS ([#1748](#1748)) ([e7df36b](e7df36b))
🎉 This change has been released in version 2.7.2 |
* commit 'ef9b00de9eeeca7fddfe9439141f5141ff5dac02': (86 commits) chore(release): 3.0.0 [skip ci] ci: Fix release workflow (parse-community#1782) feat: Remove `ParseFacebookUtils` and `ParseTwitterUtils` (parse-community#1779) feat: Add `PFObject.isDataAvailableForKey` to check if data is available for individual key (parse-community#1756) ci: Bump ip from 2.0.0 to 2.0.1 (parse-community#1772) ci: Fix failing CI by pinning bundler version (parse-community#1778) refactor: Remove Carthage dependency (parse-community#1763) refactor: Remove OCMock Carthage dependency (parse-community#1754) ci: Run CI on Xcode 15 and macOS 13 (parse-community#1753) refactor: Update ruby dependencies (parse-community#1752) refactor: Remove framework builder for assets (parse-community#1751) chore(release): 2.7.3 [skip ci] fix: Compilation errors in `ParseLiveQuery` using `Starscream` 4.0.6 (parse-community#1749) docs: Add changelog note about missing assets (parse-community#1750) chore(release): 2.7.2 [skip ci] fix: Compilation errors `Undefined symbol` and `SystemConfiguration not found` on watchOS (parse-community#1748) ci: Remove publishing release assets (parse-community#1745) ci: Fix and build Starter Projects (parse-community#1744) chore(release): 2.7.1 [skip ci] fix: Compilation error on macOS `Undefined symbol: OBJC_CLASS$_PFProductsRequestHandler` (parse-community#1739) ...
New Pull Request Checklist
Issue Description
Building the framework against watchOS starter project won't build
Closes: #1746
Closes: #1743
Approach
TODOs before merging