Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix codecov not reporting #1216

Merged
merged 8 commits into from
Aug 18, 2024
Merged

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Aug 17, 2024

New Pull Request Checklist

Issue Description

Codecov not reporting, see:

https://github.com/parse-community/Parse-SDK-Android/actions/runs/10430424460/job/28890986911?pr=1213

Approach

Fix codecov.

Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title ci: fix Codecov ci: Fix Codecov Aug 17, 2024
Copy link

parse-github-assistant bot commented Aug 17, 2024

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@mtrezza mtrezza changed the title ci: Fix Codecov ci: fix Codecov not reporting Aug 17, 2024
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title ci: fix Codecov not reporting ci: Fix Codecov not reporting Aug 17, 2024
@mtrezza mtrezza changed the title ci: Fix Codecov not reporting ci: Fix codecov not reporting Aug 17, 2024
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.45%. Comparing base (83aec68) to head (fdd9488).
Report is 1 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #1216       +/-   ##
=============================================
+ Coverage      0.00%   66.45%   +66.45%     
- Complexity        0     2275     +2275     
=============================================
  Files           124      124               
  Lines         10076    10076               
  Branches       1359     1359               
=============================================
+ Hits              0     6696     +6696     
+ Misses        10076     2845     -7231     
- Partials          0      535      +535     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abubkr-hago
Copy link

I think code coverage is incorrectly configured in the gradle build, I opened index.html in parse/build/jacoco/jacocoHtml and it looks like it is producing a 100% missed coverage.

jacoco_html
Can you confirm this as well?

@mtrezza
Copy link
Member Author

mtrezza commented Aug 17, 2024

I haven't tested this locally, but that may be what is causing the 0 coverage.

@mtrezza
Copy link
Member Author

mtrezza commented Aug 17, 2024

@abubkr-hago Good news, I got the coverage report working. The tests were not executed hence no coverage. Bad news, 9 tests are failing. Would you want to look into how to fix them? It doesn't seem to be anything major, only test-internal things. I've opened #1217 for that.

@mtrezza mtrezza merged commit 86a3157 into parse-community:master Aug 18, 2024
4 of 5 checks passed
@mtrezza mtrezza deleted the ci/fix-codedov branch August 18, 2024 00:30
@mtrezza mtrezza mentioned this pull request Aug 18, 2024
4 tasks
@abubkr-hago
Copy link

Nice Work, I'll definitely give them a look.

@abubkr-hago
Copy link

abubkr-hago commented Aug 18, 2024

The tests were not executed hence no coverage.

If you meant the tests were not running locally, can you try changing AndroidStudio JDK to 11 and try with JUnitPlatform enabled?.
With this approach Jacoco generates 0% coverage reports for me.

@mtrezza mtrezza restored the ci/fix-codedov branch November 1, 2024 21:06
@mtrezza mtrezza deleted the ci/fix-codedov branch November 1, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants